potiuk commented on code in PR #39908:
URL: https://github.com/apache/airflow/pull/39908#discussion_r1666825880
##########
tests/_internals/forbidden_warnings.py:
##########
@@ -62,6 +62,11 @@ def pytest_itemcollected(self, item: pytest.Item):
# Add marker at the beginning of the markers list. In this case,
it does not conflict with
# filterwarnings markers, which are set explicitly in the test
suite.
item.add_marker(pytest.mark.filterwarnings(f"error::{fw}"),
append=False)
+ item.add_marker(
Review Comment:
As mentioned above - after looking at it - I changed my mind and I think we
should at least have a way to not issue warning (and maybe use it in tests) -
so likely 3-state configuration: consistent, legacy (default - with warnings),
legacy-nowarning. I foresee a number of people will have a problem with
switching to consistent metrics and might defer it till airlfow 3 so finding a
way to disable the warnings is a good idea (and we could set the
"legacy-no-warning" setting to be default in unit tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
