dirrao commented on code in PR #39908:
URL: https://github.com/apache/airflow/pull/39908#discussion_r1666863294


##########
tests/_internals/forbidden_warnings.py:
##########
@@ -62,6 +62,11 @@ def pytest_itemcollected(self, item: pytest.Item):
             # Add marker at the beginning of the markers list. In this case, 
it does not conflict with
             # filterwarnings markers, which are set explicitly in the test 
suite.
             item.add_marker(pytest.mark.filterwarnings(f"error::{fw}"), 
append=False)
+        item.add_marker(

Review Comment:
   Earlier code issues warning on each metric published. Now, we have moved 
this to the class level. It will be issued only during the module load time. So 
that way, the number of warnings are less and more informative to users. Please 
do let me know your thoughts on this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to