potiuk commented on code in PR #40635:
URL: https://github.com/apache/airflow/pull/40635#discussion_r1667731797
##########
airflow/www/templates/appbuilder/navbar_menu.html:
##########
@@ -18,7 +18,12 @@
#}
{% macro menu_item(item) %}
- <a href="{{item.get_url()}}">{{_(item.label)}}</a>
+ {% set url = item.get_url() %}
+ {% if 'apache' in url %}
Review Comment:
I think ust `apache` here is not enough I believe we should check for valid
URLs that we know can be used here:
* development docs from s3
* https://github.com/apache/airflow
* https://airflow.apache.org/
Just having `apache` - might accidentally be in someones's URL (not very
likely but possible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
