VICIWUOHA commented on code in PR #40635:
URL: https://github.com/apache/airflow/pull/40635#discussion_r1667733515


##########
airflow/www/templates/appbuilder/navbar_menu.html:
##########
@@ -18,7 +18,12 @@
 #}
 
 {% macro menu_item(item) %}
-  <a href="{{item.get_url()}}">{{_(item.label)}}</a>
+  {% set url = item.get_url() %}
+  {% if 'apache' in url %}

Review Comment:
   Thanks @potiuk 
   Ok, got this , would you suggest we go explicit  for these two/ three?
   
   something like "if url in [https://github.com/apache/airflow, 
https://airflow.apache.org/, ]"....
   
   since ,again this macro, is scoped to menu items.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to