kacpermuda commented on code in PR #40173:
URL: https://github.com/apache/airflow/pull/40173#discussion_r1648642686
##########
airflow/datasets/__init__.py:
##########
@@ -118,6 +118,23 @@ def coerce_to_uri(value: str | Dataset) -> str:
return _sanitize_uri(str(value))
+def is_uri_normalized(uri: str) -> bool:
Review Comment:
So, just to clarify, currently uri normalizers defined for some schemas
(added in AIP-60) do not actually normalize the URI? Maybe we should change
that by modifying the normalizers and adding some tests?
I've added `Dataset.normalized_uri` property, does it make sense?
~~The other option that you mentioned I can just change the name to
`_is_uri_compliant` (why can't it be public?), and the when translating to
OpenLineage we would have to deal with whatever is returned by the normalizer,
without assuming the URI is normalized - so probably just adding more tests for
different cases of the URI.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
