uranusjr commented on code in PR #40173:
URL: https://github.com/apache/airflow/pull/40173#discussion_r1675155261
##########
airflow/datasets/__init__.py:
##########
@@ -118,6 +118,23 @@ def coerce_to_uri(value: str | Dataset) -> str:
return _sanitize_uri(str(value))
+def is_uri_normalized(uri: str) -> bool:
Review Comment:
This has been changed but I think what I was trying to say is, the way you
implemented this function, it would return True for non-normalised URIs. The
normalisation function always normalises the URI, but you didn’t use that
normalised result, so the function only checks if the input _can_ be
normalised, not if it _is already_ normalised as the name suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
