MRLab12 commented on code in PR #40377:
URL: https://github.com/apache/airflow/pull/40377#discussion_r1674570652
##########
airflow/providers/ssh/operators/ssh.py:
##########
@@ -192,9 +192,20 @@ def execute(self, context=None) -> bytes | str:
enable_pickling = conf.getboolean("core", "enable_xcom_pickling")
if not enable_pickling:
result = b64encode(result).decode("utf-8")
+
+ self.on_kill()
Review Comment:
I was trying to get a better sense of what the use case for `on_kill` was
going to be. From what I understood, some SSH connections were not being closed
and thought that the changes needed for issue #40343 was to ensure every
connection closes when executing an SSH command. What your suggesting makes
total sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
