o-nikolas commented on code in PR #40377:
URL: https://github.com/apache/airflow/pull/40377#discussion_r1676560976


##########
airflow/providers/ssh/operators/ssh.py:
##########
@@ -192,9 +192,20 @@ def execute(self, context=None) -> bytes | str:
         enable_pickling = conf.getboolean("core", "enable_xcom_pickling")
         if not enable_pickling:
             result = b64encode(result).decode("utf-8")
+
+        self.on_kill()

Review Comment:
   @MRLab12  You're playing with the timeout of the ssh connection. The timeout 
that triggers `on_kill` is a general mechanism of timing out a task. If you 
search the code base you'll see the uses of on_kill fairly easily. It is also 
triggered when we handle  signals.
   
   timeout:
   
https://github.com/apache/airflow/blob/6b9214508ae8ff4d6d39e9ecda5138b5ba717ceb/airflow/models/taskinstance.py#L761
   
   signal handling:
   
https://github.com/apache/airflow/blob/6b9214508ae8ff4d6d39e9ecda5138b5ba717ceb/airflow/models/taskinstance.py#L2940
  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to