Lee-W commented on code in PR #40693:
URL: https://github.com/apache/airflow/pull/40693#discussion_r1677389718
##########
airflow/datasets/__init__.py:
##########
@@ -233,7 +265,15 @@ class _DatasetBooleanCondition(BaseDataset):
def __init__(self, *objects: BaseDataset) -> None:
if not all(isinstance(o, BaseDataset) for o in objects):
raise TypeError("expect dataset expressions in condition")
- self.objects = objects
+
+ expanded_objects = []
+ for obj in objects:
+ if isinstance(obj, Dataset):
+ expanded_objects.append(obj)
+ elif isinstance(obj, DatasetAlias):
+ expanded_objects.extend(obj.expand_datasets())
Review Comment:
just tested, we'll need to do someting like `[ds for _, ds in
obj.iter_datatset()]` so that's won't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
