kacpermuda commented on PR #40854: URL: https://github.com/apache/airflow/pull/40854#issuecomment-2236823634
> > Why not attach it to some new facet as AirflowDagRunFacet? > > What should be the key of this facet? `"airflow"` or something else? For OL consumer, having runEvents with facets stored with the same key, but having different fields for Task and DAG runs, is not very comfortable. > > Should `AirflowRunFacet` be renamed to `AirflowTaskRunFacet`, for consistency? We can think of a new name, that would not be confusing. I don't think we even could go with another run facet with `airflow` as key, as from spec perspective it would be a duplicate, there is no distinction between DAG and Task run facet from the spec perspective. I think the renaming you propose would not be a big issue, as it would not change the spec, only the import, so we would have to keep old name for compatibility. Personally, I would avoid doing any changes to AirflowRunFacet if possible. I think renaming will not be necessary if we come up with a better name for the new one 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
