dolfinus commented on code in PR #40854:
URL: https://github.com/apache/airflow/pull/40854#discussion_r1684201354
##########
airflow/providers/openlineage/plugins/listener.py:
##########
@@ -420,7 +421,8 @@ def on_dag_run_running(self, dag_run: DagRun, msg: str) ->
None:
nominal_end_time=data_interval_end,
# AirflowJobFacet should be created outside ProcessPoolExecutor
that pickles objects,
# as it causes lack of some TaskGroup attributes and crashes event
emission.
- job_facets={**get_airflow_job_facet(dag_run=dag_run)},
+ job_facets=get_airflow_job_facet(dag_run=dag_run),
+ run_facets=get_airflow_dag_run_facet(dag_run),
Review Comment:
Almost of logic could be moved from `on_dag_run_running` to `dag_started`.
Is `OpenLineageAdapter` responsible for building facets in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
