dstandish commented on code in PR #40867:
URL: https://github.com/apache/airflow/pull/40867#discussion_r1683336091
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -385,18 +385,25 @@ def attempt_task_runs(self):
)
self.pending_tasks.append(ecs_task)
else:
- self.send_message_to_task_logs(
- logging.ERROR,
- "ECS task %s has failed a maximum of %s times. Marking
as failed. Reasons: %s",
- task_key,
- attempt_number,
- ", ".join(failure_reasons),
- ti=task_key,
+ reasons_str = ", ".join(failure_reasons)
+ self.log_task_event(
+ record=Log(
+ event="ecs executor queue error",
Review Comment:
isn't it an error specifically with regard to executor trying to queue this
task? separately, the reason i didn't put "task" here and elsewhere is because
it's already clear from the log record that it is specific to a task so i think
it does not need to be stated and we can just assume it's task and be specific
about the type of task error. in the context where this is presented in the
UI, we are showing all events related to the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
