vincbeck commented on code in PR #40867:
URL: https://github.com/apache/airflow/pull/40867#discussion_r1683343804
##########
airflow/providers/amazon/aws/executors/ecs/ecs_executor.py:
##########
@@ -385,18 +385,25 @@ def attempt_task_runs(self):
)
self.pending_tasks.append(ecs_task)
else:
- self.send_message_to_task_logs(
- logging.ERROR,
- "ECS task %s has failed a maximum of %s times. Marking
as failed. Reasons: %s",
- task_key,
- attempt_number,
- ", ".join(failure_reasons),
- ti=task_key,
+ reasons_str = ", ".join(failure_reasons)
+ self.log_task_event(
+ record=Log(
+ event="ecs executor queue error",
Review Comment:
`task` is definitely overused xD Here I am referring to ECS task, which is
the name used in ECS to refer to a job. But here similarly to my previous
comment, we are dequeing jobs from a queue and try to execute them. This
execution fail but it is not a queue failure to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
