kacpermuda commented on code in PR #40854:
URL: https://github.com/apache/airflow/pull/40854#discussion_r1684242857
##########
airflow/providers/openlineage/utils/utils.py:
##########
@@ -307,6 +308,17 @@ class TaskGroupInfo(InfoJsonEncodable):
]
+def get_airflow_dag_run_facet(dag_run: DagRun) -> dict[str, BaseFacet]:
+ if not dag_run.dag:
+ return {}
+ return {
+ "airflow_dagRun": AirflowDagRunFacet(
Review Comment:
Personally I'd stick with current name, even though it's not compliant with
the doc. Maybe we should adjust it, but sending duplicates for a long time for
newly created facet just because of this mistakes seems like on overkill for
me. I think in more and more places we are going with camelCase instead (e.x.
[BQ
mixin](https://github.com/apache/airflow/blob/42a96412b4cbe309c5c9f0f298a5514de838e9d7/airflow/providers/google/cloud/openlineage/mixins.py#L127))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
