shahar1 commented on code in PR #40915:
URL: https://github.com/apache/airflow/pull/40915#discussion_r1685805342


##########
airflow/sensors/base.py:
##########
@@ -182,7 +184,11 @@ def __init__(
         self.mode = mode
         self.exponential_backoff = exponential_backoff
         self.max_wait = self._coerce_max_wait(max_wait)
+        if soft_fail is True and never_fail is True:
+            raise ValueError("soft_fail and never_fail are mutually exclusive, 
you can not provide both.")

Review Comment:
   I think that it is important to clarify the mutual exclusivness also in the 
docstrings (both in `soft_fail` and `never_fail`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to