Lee-W commented on PR #40915:
URL: https://github.com/apache/airflow/pull/40915#issuecomment-2242280843
> yes I can introduce a skip_policy parameters and keep the other settings.
Yes, this is something we could discuss whether we want to make it a new
feature and I'm ok with it.
> Yes I updated the doc in the second PR
https://github.com/apache/airflow/pull/40923
It looks like a breaking change to me and not something we can fix just by
updating the description. It's possible that `soft_fail` was not named well
enough back when it was introduced, but the description states how it used to
work. `Set to true to mark the task as SKIPPED on failure.` sounds like any
kind of failure to me. Unless I misunderstood this descipriont, we should even
revert this PR.
@shahar1 's suggestion on changing it to `skip_on_failure` is great, and
`skip_on_any_failure` is ok for me as well. We can choose to deprecate
`soft_fail` and instead use `skip_on_failure`/`skip_on_any_failure` in the
future, or even change the behavior of `soft_fail` but I think that should only
happen in the next major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
