eladkal commented on code in PR #41122: URL: https://github.com/apache/airflow/pull/41122#discussion_r1698678440
########## airflow/providers/airbyte/provider.yaml: ########## Review Comment: Please add `4.0.0` under `versions:` ########## airflow/providers/airbyte/provider.yaml: ########## @@ -50,6 +50,7 @@ versions: dependencies: - apache-airflow>=2.7.0 - apache-airflow-providers-http + - airbyte-api>=0.51.0 Review Comment: Do we still need http provider as dependency if we move to sdk? ########## docs/apache-airflow-providers-airbyte/operators/airbyte.rst: ########## @@ -38,10 +38,8 @@ create in Airbyte between a source and destination synchronization job. Use the ``airbyte_conn_id`` parameter to specify the Airbyte connection to use to connect to your account. -Airbyte currently supports two different API's. The first one is the `Config API <https://airbyte-public-api-docs.s3.us-east-2.amazonaws.com/rapidoc-api-docs.html>`_ -which is specifically used for Open Source Airbyte Instances. The second is the `Cloud API <https://reference.airbyte.com/reference/start>`_ -which is used for the Airbyte Cloud Service. If you are using Airbyte's Cloud service, -then you will need to specify ``api_type="cloud"`` as part of the Operator's parameters. +Airbyte now offers a single method to authenticate for Cloud and OSS users. Review Comment: ```suggestion Airbyte offers a single method to authenticate for Cloud and OSS users. ``` ########## airflow/providers/airbyte/hooks/airbyte.py: ########## @@ -50,80 +46,63 @@ class AirbyteHook(HttpHook): conn_type = "airbyte" hook_name = "Airbyte" - RUNNING = "running" - SUCCEEDED = "succeeded" - CANCELLED = "cancelled" - PENDING = "pending" - FAILED = "failed" - ERROR = "error" - INCOMPLETE = "incomplete" Review Comment: Please add entry of 4.0.0 in the changelog of the provider with 1-2 paragraph explaining how users should migrate from previous version to the current one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
