uranusjr commented on code in PR #40722:
URL: https://github.com/apache/airflow/pull/40722#discussion_r1709003222
##########
airflow/models/mappedoperator.py:
##########
@@ -839,6 +841,8 @@ def unmap(self, resolve: None | Mapping[str, Any] |
tuple[Context, Session]) ->
from airflow.serialization.serialized_objects import
SerializedBaseOperator
op = SerializedBaseOperator(task_id=self.task_id, params=self.params,
_airflow_from_mapped=True)
+ if "upstream_task_ids" not in self.operator_class: #
upstream_task_ids is not serialized
+ self.operator_class["upstream_task_ids"] =
list(self.upstream_task_ids)
Review Comment:
No; I think those are the reasons they are not serialised in the first
place. (Plus also if you serialise both fields there’s always a risk they are
not in sync.)
I think we should try to commit one way or the other though. If we want to
serialise, we should always do that; if we don’t, we should get this
information another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
