kacpermuda commented on code in PR #40722:
URL: https://github.com/apache/airflow/pull/40722#discussion_r1709636665


##########
airflow/models/mappedoperator.py:
##########
@@ -839,6 +841,8 @@ def unmap(self, resolve: None | Mapping[str, Any] | 
tuple[Context, Session]) ->
         from airflow.serialization.serialized_objects import 
SerializedBaseOperator
 
         op = SerializedBaseOperator(task_id=self.task_id, params=self.params, 
_airflow_from_mapped=True)
+        if "upstream_task_ids" not in self.operator_class:  # 
upstream_task_ids is not serialized
+            self.operator_class["upstream_task_ids"] = 
list(self.upstream_task_ids)

Review Comment:
   I've tried quickly adding this field to serialisation, but it does not look 
trivial to me, I'm not so sure anymore that it's worth doing and I can't spend 
to much time on this right now unfortunately. If it can't be merged in current 
form let's close the PR for now - maybe I'll revisit in the future 😄 For now 
I'll advice the OL consumers to use AirflowDagFacet that has the taskTree with 
all the task dependencies in the DAG. Thanks for the comments and engagement !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to