jscheffl commented on code in PR #41516:
URL: https://github.com/apache/airflow/pull/41516#discussion_r1720260008


##########
airflow/www/static/js/components/RenderedJsonField.tsx:
##########
@@ -47,7 +47,7 @@ const JsonParse = (content: string | object) => {
       contentJson = content;
     }
     contentFormatted = JSON.stringify(contentJson, null, 4);
-    isJson = true;
+    isJson = Number.isNaN(contentJson); // ensure numbers/bool are not treated 
as JSON

Review Comment:
   Uuups. Yes. Reading docs helps. Still I am wondering why actually it _was_ 
working with this.
   
   Anyway, how about as I pushed a different approach? After parsing as JSON 
should be an object (which is true for Array+Dict)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to