jscheffl commented on code in PR #41516:
URL: https://github.com/apache/airflow/pull/41516#discussion_r1720782169
##########
airflow/www/static/js/components/RenderedJsonField.tsx:
##########
@@ -47,7 +47,7 @@ const JsonParse = (content: string | object) => {
contentJson = content;
}
contentFormatted = JSON.stringify(contentJson, null, 4);
- isJson = true;
+ isJson = typeof contentJson === "object"; // ensure numbers/bool are not
treated as JSON
Review Comment:
Oh. You are really good. Did not have "NULL" in my test set as in all my
examples NULL was never persisted in XCom, in these cases just no XCom was
stored. But actually if I try we have even a second problem with NULL in the
XCom value. API returns an error so... need to fix this as well.
Added NULL to the party, updated screenshot in PR above how it comes out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
