potiuk commented on code in PR #41390:
URL: https://github.com/apache/airflow/pull/41390#discussion_r1721050765
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None,
include_try_number: bool
if include_try_number:
labels.update(try_number=ti.try_number)
# In the case of sub dags this is just useful
- if context["dag"].parent_dag:
- labels["parent_dag_id"] = context["dag"].parent_dag.dag_id
+ if getattr(context["dag"], "parent_dag", False):
+ labels["parent_dag_id"] = context["dag"].parent_dag.dag_id #
type: ignore[attr-defined]
Review Comment:
from what I see - they wil ljust miss "parent_dag_id" label, as getattr wll
handle lack of parent_dag field - and yes, it's a breaking change for those who
relied on subdags, but that's expected in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
