kaxil commented on code in PR #41390:
URL: https://github.com/apache/airflow/pull/41390#discussion_r1721684927
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -495,8 +495,9 @@ def _get_ti_pod_labels(context: Context | None = None,
include_try_number: bool
if include_try_number:
labels.update(try_number=ti.try_number)
# In the case of sub dags this is just useful
- if context["dag"].parent_dag:
- labels["parent_dag_id"] = context["dag"].parent_dag.dag_id
+ if getattr(context["dag"], "parent_dag", False):
+ labels["parent_dag_id"] = context["dag"].parent_dag.dag_id #
type: ignore[attr-defined]
Review Comment:
>We don't have to. It happens automatically via getattr - it will work in
backwards-compatible way if the context will contain parent_dag automatically.
Precisely, this check is backwards-compatible. For someone using sub-dags,
it works same as before.
I'll add a TODO in a separate PR to remove this check when we drop Airflow 2
support in Providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
