LipuFei commented on code in PR #41524:
URL: https://github.com/apache/airflow/pull/41524#discussion_r1722812751
##########
chart/values.schema.json:
##########
@@ -516,16 +516,7 @@
"description": "Airflow executor.",
"type": "string",
"x-docsSection": "Common",
- "default": "CeleryExecutor",
- "enum": [
- "LocalExecutor",
- "LocalKubernetesExecutor",
- "CeleryExecutor",
- "KubernetesExecutor",
- "CeleryKubernetesExecutor",
-
"airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor",
- "airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor"
- ]
+ "default": "CeleryExecutor"
Review Comment:
What if we keep this as a list of enums? Then, in the value, we concatenate
them with `,` into a comma separated list? Downside is, this is still a fixed
list of executors. You cannot specify custom executors or use short names such
as `airflow.providers.amazon.aws.executors.ecs.AwsEcsExecutor:AwsEcsExecutor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
