moiseenkov commented on PR #41637: URL: https://github.com/apache/airflow/pull/41637#issuecomment-2301859532
> Instead of a pre-commit check and enforcing the style of the message did you consider adding extra (required) args to the deprecated decorator: > > ```python > @deprecated( > reason="Please use `create_build_without_waiting_for_result`", > removed_after="2025-03-01", > category=AirflowProviderDeprecationWarning, > ) > ``` > > That way the message can be generated programaticaly and be consistent that way -- no need for a precommit check then? This is the perfect approach, and I'd be happy to apply it, but as it was discussed in https://github.com/apache/airflow/pull/37075#discussion_r1484366520, implementing this new decorator on the Airflow core side would make it very difficult to use in providers as they would have to bump Airflow version in their requirements. The idea of releasing such a decorator in a separated provider package seems like a great solution! Is there any chance to implement it any time soon? @kacpermuda , @potiuk Otherwise, our team would be happy to merge the current PR (with date format fixed) now in order to bring some order to the google provider package now. And once the new provider with the structured deprecation decorator is released, we could adopt the current changes accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
