eladkal commented on code in PR #41637:
URL: https://github.com/apache/airflow/pull/41637#discussion_r1726378178
##########
airflow/providers/google/cloud/hooks/kubernetes_engine.py:
##########
@@ -139,10 +139,8 @@ def get_cluster_manager_client(self) ->
ClusterManagerClient:
# To preserve backward compatibility
# TODO: remove one day
@deprecated(
- reason=(
- "The get_conn method has been deprecated. "
- "You should use the get_cluster_manager_client method."
- ),
+ reason="The get_conn method is deprecated and will be removed after
01.11.2024. "
Review Comment:
> separately: why not version instead of date?
I think dates make it more actionable and helps to prioritize when you will
take action. Specificing version doesn't provide information if you must take
action now or you can postpone it. It just invites the question when will this
version be released? And we may not always know the answer. Consider also that
some deprecations are not so simple do handle and requires effort (3rd party
SDK that breakes inferface etc...) so it may not just be 5 min work and get rid
of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
