MaksYermak commented on code in PR #41770:
URL: https://github.com/apache/airflow/pull/41770#discussion_r1732466156
##########
airflow/providers/google/cloud/hooks/vertex_ai/generative_model.py:
##########
@@ -56,9 +56,13 @@ def get_text_embedding_model(self, pretrained_model: str):
model = TextEmbeddingModel.from_pretrained(pretrained_model)
return model
- def get_generative_model(self, pretrained_model: str) -> GenerativeModel:
+ def get_generative_model(
Review Comment:
@CYarros10 if you want to update the name for required parameters in this
case you need to deprecate the whole method and create a new method with new
names for parameters. Could you please make a changes to this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
