potiuk commented on code in PR #41564: URL: https://github.com/apache/airflow/pull/41564#discussion_r1733251520
########## airflow/example_dags/example_branch_day_of_week_operator.py: ########## Review Comment: Yeah. But currently the "examples" in core are automatically enabled when you choose to show them - and I think those "standard provider" examples should also show up - because otherwise, when we move all "core" operators to providers, there will be no more examples to show in "airflow". So I am ok with moving the examples to "standard provider" - but there we should figure out how to show them when we choose "show examples = True" (and we likely do not want to show all the few 100 system tests we have from other providers). Also those examples are part of the "core" documentation currently, and we should find them to be prominently visible in the docs - without having to go to "standard provider" documentation (I think) - just to make them better discoverable (currently I can imagine you know you should go to Google provider docs when you are looking for google examples - but people might not be aware they should look at standard provider when they are looking for PythonVirtualenv example - and the doc pages describing those should **likely** be in Airflow "core" docs. So for me - this is a sign that "standard" provider's examples should be treated somewhat differently, but I am open to hear what others think about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
