potiuk commented on code in PR #41564: URL: https://github.com/apache/airflow/pull/41564#discussion_r1733028882
########## airflow/example_dags/example_branch_day_of_week_operator.py: ########## Review Comment: The import error - I explained in Slack - we migtht (likely) make the provider to be only Airflow 2.10+ compatible to allow people to change the imports in 2.10 as part of "recommended" migration process. I believe @ashb planned to get the old imports to continue to work with https://docs.python.org/3/glossary.html#term-meta-path-finder with deprecation) - I will let him comment on it. But for the reasons explained above (examples are really part of "core" airflow and changing providers to contribute examples when "show examples" are enabled might be an overkill and since this provider is going to be "preinstalled" - I think adding a feature to read examples from providers in this case might be quite an overkill - but maybe it makes sense if you think that @eladkal -> it **could** be done possibly by just adding "providers/*/examples" to the paths when DAGs are searched. We would likely also have to figure out how to filter out "examples/system tests" in this case, because then "show examples" might led to a huge set of examples visible. Also in this case we should move all the documentation for the standard operators to "provider" documentation. But maybe that's a good idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
