uranusjr commented on code in PR #41818:
URL: https://github.com/apache/airflow/pull/41818#discussion_r1734343398
##########
airflow/utils/db.py:
##########
@@ -1194,7 +1194,7 @@ def check_run_id_null(session: Session) -> Iterable[str]:
invalid_dagrun_filter = or_(
dagrun_table.c.dag_id.is_(None),
dagrun_table.c.run_id.is_(None),
- dagrun_table.c.execution_date.is_(None),
+ dagrun_table.c.logical_date.is_(None),
Review Comment:
This is for data integrity checks in `upgradedb`. But I’m thinking maybe we
can just drop the checks entirely?
If we _require_ users to upgrade to 2.10 (or even 2.11) before upgrading,
they should have already run those checks and have data integrity (enforced by
the database) when they upgrade to 3.0.
(Same for the column renames below.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
