johnhoran opened a new pull request, #41868:
URL: https://github.com/apache/airflow/pull/41868
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
closes #41867
This is to fix a bug in the Kubernetes pod operator where if the task wakes
up from a deferred state to collect logs. If the task completes during that
time then operator won't defer it again, however it also doesn't evaluate the
reason for the completion, so if the pod ends in an error, it will still be
marked as successful.
The fix here is to always defer when the task resumes while the pod is in a
running state, so that the next resume will notice the pod exit and act
accordingly, however alternatively we could check the pod exit state and skip
the deferment. I'm happy to amend the PR if this is preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
