dstandish commented on code in PR #41868:
URL: https://github.com/apache/airflow/pull/41868#discussion_r1742787081
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -787,9 +774,27 @@ def trigger_reentry(self, context: Context, event:
dict[str, Any]) -> Any:
if pod_log_status.running:
self.log.info("Container still running; deferring
again.")
self.invoke_defer_method(pod_log_status.last_log_time)
+ else:
+ event = event.copy()
Review Comment:
don't really like the idea that we're changing the event. the event is what
came from the trigger. there's not really a need to mess with it. yes we have
checked if the pod status has changed. but we don't need to use the event to
communicate this. the event can be left alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
