shahar1 commented on code in PR #41804:
URL: https://github.com/apache/airflow/pull/41804#discussion_r1738153560


##########
airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -22,11 +22,13 @@
 from pathlib import Path

Review Comment:
   General concern - this PR includes both changes to the FAB provider and to 
Airflow core. While it seems that the changes to the FAB provider address 
future compatbility, I think that it would be safer to make them in a separate 
PR so we could mark the `3.0.0` milestone properly and to avoid confusion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to