gopidesupavan commented on code in PR #41712:
URL: https://github.com/apache/airflow/pull/41712#discussion_r1740080601
##########
airflow/providers/google/cloud/triggers/kubernetes_engine.py:
##########
@@ -305,19 +307,35 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
if self.get_logs or self.do_xcom_push:
pod = await self.hook.get_pod(name=self.pod_name,
namespace=self.pod_namespace)
if self.do_xcom_push:
+ kubernetes_provider =
ProvidersManager().providers["apache-airflow-providers-cncf-kubernetes"]
+ kubernetes_provider_name = kubernetes_provider.data["package-name"]
+ kubernetes_provider_version = kubernetes_provider.version
+ min_version = "8.0.1"
Review Comment:
are you referring to poll_interval?, it is already present in previous
versions, but not using in `GKEJobTrigger` when calling these functions
`wait_until_container_started`, `wait_until_container_complete`,
`wait_until_job_complete`. so i have updated. not sure for this we have to
update min_version to 8.4.2 and the poll_interval is in google cloud provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
