eladkal commented on code in PR #41712:
URL: https://github.com/apache/airflow/pull/41712#discussion_r1740066728
##########
airflow/providers/google/cloud/triggers/kubernetes_engine.py:
##########
@@ -305,19 +307,35 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
if self.get_logs or self.do_xcom_push:
pod = await self.hook.get_pod(name=self.pod_name,
namespace=self.pod_namespace)
if self.do_xcom_push:
+ kubernetes_provider =
ProvidersManager().providers["apache-airflow-providers-cncf-kubernetes"]
+ kubernetes_provider_name = kubernetes_provider.data["package-name"]
+ kubernetes_provider_version = kubernetes_provider.version
+ min_version = "8.0.1"
Review Comment:
I think min version is 8.4.2?
This change relays on releasing new version of Kubernetes provider. 8.4.1
doesn't contain the pull_interval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
