potiuk commented on code in PR #41921:
URL: https://github.com/apache/airflow/pull/41921#discussion_r1739968045
##########
airflow/io/path.py:
##########
@@ -198,7 +198,7 @@ def replace(self, target) -> ObjectStoragePath:
Returns the new Path instance pointing to the target path.
"""
- return self.rename(target, overwrite=True)
+ return self.rename(target)
Review Comment:
@bolkedebruin @ap-- -> mypy complains and there does not seem to be
overwrite kwarg when you look at the code . I am not sure if there was a reason
it was added in a first place - maybe it is needed somehow to pass down to
unrelying implementations?
Please advice if this is a good idea to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
