jscheffl commented on code in PR #41921:
URL: https://github.com/apache/airflow/pull/41921#discussion_r1740162017
##########
airflow/io/path.py:
##########
@@ -198,7 +198,7 @@ def replace(self, target) -> ObjectStoragePath:
Returns the new Path instance pointing to the target path.
"""
- return self.rename(target, overwrite=True)
+ return self.rename(target)
Review Comment:
If @bolkedebruin is not able to respond then we could merge and leave a link
with the bug ticket behind?
##########
airflow/providers/common/io/xcom/backend.py:
##########
@@ -142,7 +142,12 @@ def serialize_value(
base_path = _get_base_path()
while True: # Safeguard against collisions.
- p = base_path.joinpath(dag_id, run_id, task_id,
f"{uuid.uuid4()}{suffix}")
+ p = base_path.joinpath(
+ dag_id or "NO_DAG_ID",
Review Comment:
I was hoping you know a reason why the fileds can be None - I think actually
the interface definition is "broken by design" because we never store XCom w/o
DAG ID, Run ID or Task ID. I first thought making an assert but was not sure if
this is a hidden feature :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
