feluelle commented on a change in pull request #5786: [AIRFLOW-5170]
[AIRFLOW-5256] Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r323778241
##########
File path: tests/utils/log/elasticmock/fake_elasticsearch.py
##########
@@ -124,6 +135,17 @@ def get(self, index, id, doc_type='_all', params=None):
return result
+ def find_document(self, doc_type, id, index, result):
Review comment:
Is that, `find_document_in_searchable_index`and `match_must_phrase` intended
to be used from outside this scope. If not I think it should be private or
internal starting with `_`. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
