feluelle commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r323770850
########## File path: airflow/kubernetes/volume_mount.py ########## @@ -24,26 +24,25 @@ class VolumeMount(K8SModel): - """Defines Kubernetes Volume Mount""" - + """Initialize a Kubernetes Volume Mount. Used to mount pod level volumes to + running container. Review comment: Personally I think it is better for multi-line docs to start the text on the next line. This ``` """ foo """ ``` instead of ``` """foo """ ``` Actually.. I always prefer the first one even to `"""foo"""` (but I am fine with both) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
