dstandish commented on code in PR #41868:
URL: https://github.com/apache/airflow/pull/41868#discussion_r1744085339
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -745,6 +746,7 @@ def trigger_reentry(self, context: Context, event:
dict[str, Any]) -> Any:
grab the latest logs and defer back to the trigger again.
"""
self.pod = None
+ pod_status = event["status"]
Review Comment:
ok it's subtle but you are still conflating the event "status" with the pod
status. i recommend keeping them separate. you can either consider each
independently (e.g. if pod_status is this, elif event_status is this etc) or
you can add a new variable that essentially aggregates the pod status and event
status. you can see why this matters if you look at line 787. there's no pod
status "timeout". so this could be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
