romsharon98 commented on code in PR #40757:
URL: https://github.com/apache/airflow/pull/40757#discussion_r1747672315
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -282,10 +313,57 @@ def _resolve_connection(self) -> dict[str, Any]:
def get_conn(self) -> Any:
pass
+ def _create_keytab_path_from_base64_keytab(self, base64_keytab: str,
principal: str | None) -> str:
+ _uuid = uuid.uuid4()
+ temp_dir_path = Path(tempfile.gettempdir()).resolve()
+ temp_file_name = f"airflow_keytab-{principal or _uuid}"
+
+ keytab_path = temp_dir_path / temp_file_name
+ staging_path = temp_dir_path / f".{temp_file_name}.{_uuid}"
Review Comment:
Is there a reason you added here `.{_uuid}`?
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -370,10 +448,12 @@ def _build_spark_submit_command(self, application: str)
-> list[str]:
connection_cmd += ["--executor-memory", self._executor_memory]
if self._driver_memory:
connection_cmd += ["--driver-memory", self._driver_memory]
- if self._keytab:
- connection_cmd += ["--keytab", self._keytab]
- if self._principal:
- connection_cmd += ["--principal", self._principal]
+ keytab = self._get_keytab()
+ if keytab:
+ connection_cmd += ["--keytab", keytab]
+ principal = self._get_principal()
Review Comment:
I think you can just do `self._connection["principal"]` because
[here](https://github.com/apache/airflow/pull/40757/files#diff-aa05e2f3d2472084951026f8344dbc7134cb1e3f94d626127ab9dee50fbde2c6R295)
you already did this if (same for the keytab)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
