seyoon-lim commented on code in PR #40757:
URL: https://github.com/apache/airflow/pull/40757#discussion_r1747798708
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -370,10 +448,12 @@ def _build_spark_submit_command(self, application: str)
-> list[str]:
connection_cmd += ["--executor-memory", self._executor_memory]
if self._driver_memory:
connection_cmd += ["--driver-memory", self._driver_memory]
- if self._keytab:
- connection_cmd += ["--keytab", self._keytab]
- if self._principal:
- connection_cmd += ["--principal", self._principal]
+ keytab = self._get_keytab()
+ if keytab:
+ connection_cmd += ["--keytab", keytab]
+ principal = self._get_principal()
Review Comment:
~~Looking at [this
part](https://github.com/apache/airflow/pull/40757/files#diff-aa05e2f3d2472084951026f8344dbc7134cb1e3f94d626127ab9dee50fbde2c6R461-R464),
it seems you're right about making the change. I've corrected it
(https://github.com/apache/airflow/pull/40757/commits/55007bc3401eb42bff86dfdd4cb442c0e66c4f4b).
Thanks!~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
