loucyx commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1755784818
##########
airflow/ui/src/components/DataTable/DataTable.test.tsx:
##########
@@ -20,14 +20,14 @@
import { describe, expect, it, vi } from "vitest";
import { render, screen } from "@testing-library/react";
import { DataTable } from "./DataTable.tsx";
-import { ColumnDef, PaginationState } from "@tanstack/react-table";
+import type { ColumnDef, PaginationState } from "@tanstack/react-table";
import "@testing-library/jest-dom";
-const columns: ColumnDef<{ name: string }>[] = [
+const columns: Array<ColumnDef<{ name: string }>> = [
Review Comment:
Open to change this, it was changed from `Type[]` to `Array<Type>`. There
are some scenarios in which the `Type[]` syntax can get awkward (having to use
parenthesis), but I'm more than ok reverting this back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
