loucyx commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1755789014
##########
airflow/ui/src/utils/pluralize.test.ts:
##########
@@ -22,52 +22,52 @@ import { describe, expect, it } from "vitest";
import { pluralize } from "./pluralize";
type PluralizeTestCase = {
- in: [string, number, (string | null)?, boolean?];
+ in: [string, number, string?, boolean?];
out: string;
};
-const pluralizeTestCases: PluralizeTestCase[] = [
+const pluralizeTestCases = [
{ in: ["DAG", 0, undefined, undefined], out: "0 DAGs" },
{ in: ["DAG", 1, undefined, undefined], out: "1 DAG" },
- { in: ["DAG", 12000, undefined, undefined], out: "12,000 DAGs" },
- { in: ["DAG", 12000000, undefined, undefined], out: "12,000,000 DAGs" },
+ { in: ["DAG", 12_000, undefined, undefined], out: "12,000 DAGs" },
Review Comment:
Big numbers like `12000` are automatically turned into `12_000` with the
underscore syntax to make them more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
