loucyx commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1758513812
##########
airflow/ui/package.json:
##########
@@ -7,7 +7,7 @@
"scripts": {
"dev": "vite",
"build": "tsc -b && vite build",
- "lint": "eslint . && tsc --p tsconfig.app.json",
+ "lint": "eslint --quiet && tsc --p tsconfig.app.json",
Review Comment:
Oh yup! The plan with the warnings is to fix them when we see them in our
editors, and then once that warning is no longer present in the code, just
change that `WARN` to `ERROR`. So basically a "gradual" improvement that will
lead to almost everything being just plain errors. I have a personal preference
to do the same thing you do in `www` and just make pretty much everything an
error unless is something that can be a valid exception every now and then (for
example `no-console` which should be fixed pretty much everywhere, unless
you're writing actual CLI output for Node).
I'm finally getting tired (I have insomnia, that's why I'm responding at 4AM
😓💤), I'll try to get some sleep to be productive in a few hours. Please feel
free to leave any more observations, I'll try to address them first thing
tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
