pierrejeambrun commented on code in PR #42184:
URL: https://github.com/apache/airflow/pull/42184#discussion_r1758473699


##########
.vscode/settings.json:
##########
@@ -0,0 +1,14 @@
+{

Review Comment:
   My concern is people will start forgetting about that and push a whole bunch 
of changes to `.vscode` without noticing it. (The reason it's ignore in the 
first place I believe).
   
   We are far from ready to have an official `.vscode` config that works for 
airflow `back/front/etc.` and I'm not sure we want to push one IDE over 
another, the majority of people that works on airflow are working on the python 
side and use pycharm / something else. So if we are to support 1 IDE it's most 
likely to be the JetBrains suite i.e pycharm/webstorm. (which I don't find 
great for front-end).
   
   I mean we can discuss about this, I'm sure it will bring a lot of interest 
from other contributor and most likely delay this PR. As this is not necessary 
to the ESLint config, I would recommend to open a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to