Re: [PR] Use set instead of list for dags' tags [airflow]

Sat, 21 Sep 2024 02:50:41 -0700 


bitomukesh commented on PR #41695:
URL: https://github.com/apache/airflow/pull/41695#issuecomment-2365125632

   <div>
   <h2>Changelist by Bito</h2>
       <p>This pull request implements the following key changes.</p>
   
   <div>
   <table width="100%">
   <tbody>
     <tr>
       <th>Key Change</th>
       <th>Files Impacted</th>
     </tr>
   
   <tr>
   <td width="30%">
       <b>Feature Improvement</b> - Replace list with MutableSet for DAG tags
   </td>
   <td width="70%">
   
   
   <div>
   
   
-&nbsp;[`dag.py`](https://github.com/apache/airflow/pull/41695/files#diff-62c8e300ee91e0d59f81e0ea5d30834f04db71ae74f2e155a10b51056b00b59b)
 - Changed DAG.tags to use MutableSet instead of list
   <div>
   
   
-&nbsp;[`dagbag.py`](https://github.com/apache/airflow/pull/41695/files#diff-a2cc1cc05747aab5c8f90ce72a599322d32f69fbfa1e9474655f0471d500e2df)
 - Updated type hints and method calls for DAG tags
   <div>
   
   
-&nbsp;[`serialized_objects.py`](https://github.com/apache/airflow/pull/41695/files#diff-807ca0a4fd53aeb41166621c9842b0f89b7931fc64e9a60befa36c776db45efa)
 - Updated deserialization logic for DAG tags
   <div>
   
   
-&nbsp;[`test_dag_schema.py`](https://github.com/apache/airflow/pull/41695/files#diff-56893720bf0d287f595c87966940d34bc938c1075da1be1bc9da1b460afc3348)
 - Updated tests to handle tags as a set
   <div>
   
   
-&nbsp;[`test_dag.py`](https://github.com/apache/airflow/pull/41695/files#diff-020d9b727c01b132cc07f0e2f35e93508e26f700bae5350018269a0ce487b4b7)
 - Updated tests for DAG tags as a set
   <div>
   
   
-&nbsp;[`test_dagbag.py`](https://github.com/apache/airflow/pull/41695/files#diff-c07e831bbfb252ab4bda06ea4d774e448b921788e8f3036a805f19d22fe3e8f3)
 - Updated assertions for DAG tags as a set
   <div>
   
   
-&nbsp;[`test_serialized_dag.py`](https://github.com/apache/airflow/pull/41695/files#diff-d08413a046753c7b6b376d274ce72d73ea14eb4bfe45b85ab219c8ba85bcfd07)
 - Updated tests for serialized DAG tags
   <div>
   
   
-&nbsp;[`test_dag_serialization.py`](https://github.com/apache/airflow/pull/41695/files#diff-728931416b9355bc1e0c4129413454bbede32c312857829c51c8bac7eb6400ed)
 - Updated DAG serialization tests for tags
   </div>
   </td>
   </tr>
   
   <tr>
   <td width="30%">
       <b>Documentation</b> - Add newsfragment for breaking change
   </td>
   <td width="70%">
   
   
   <div>
   
   
-&nbsp;[`41420.significant.rst`](https://github.com/apache/airflow/pull/41695/files#diff-6757ddee9e90d45fb9d1c30547922b0c82a25365aad6c5fe937bc00d138cde02)
 - Added documentation for breaking change in DAG tags
   </div>
   </td>
   </tr>
   
   </tbody>
   </table>
   </div>
   </div>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to