uranusjr commented on code in PR #41695:
URL: https://github.com/apache/airflow/pull/41695#discussion_r1747149327
##########
airflow/models/dag.py:
##########
@@ -355,7 +355,7 @@ def _create_orm_dagrun(
"doc_md": str,
"is_paused_upon_creation": bool,
"render_template_as_native_obj": bool,
- "tags": list,
+ "tags": abc.Collection,
Review Comment:
Since Airflow uses `from __future__ import annotation`, type hints become
simply strings, so runtime deprecations do not matter as long as the imports
are made in the `if TYPE_CHECKING` block.
What matters is _Mypy_ deprecating the support (it does not), not Python
itself. Airflow already uses this import quite extensively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
