gopidesupavan commented on PR #42811: URL: https://github.com/apache/airflow/pull/42811#issuecomment-2400454474
> Actualyt now, when I think of it - quarantining is not enough /not needed - what we really need is to not have mssql integration running in CI. > > If you look at selective checks -> they produce the list of "testable_integrations" : https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1298 > > Defined here: > > https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/global_constants.py#L57 > > This list is produced by selective checks here: > > https://github.com/apache/airflow/actions/runs/11226083287/job/31205948119?pr=42811#step:8:824 > > And used in the workflow that runs integration tests to produce matrix of jobs: > > https://github.com/apache/airflow/blob/main/.github/workflows/integration-tests.yml#L67 > > So all we need to do is to remove mssql from the list. > > This is actually cool - because this way you can still run the tests locally: > > ``` > breeze tessting integration-tests --integration mssql > ``` > > but they will not run in CI. yeah, your correct. that was great suggestion, let me check and update. thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
