shahar1 commented on code in PR #42582:
URL: https://github.com/apache/airflow/pull/42582#discussion_r1796472458
##########
airflow/models/taskinstance.py:
##########
@@ -3676,12 +3676,14 @@ def _schedule_downstream_tasks(
# Get a partial DAG with just the specific tasks we want to
examine.
# In order for dep checks to work correctly, we include ourself (so
# TriggerRuleDep can check the state of the task we just executed).
- partial_dag = task.dag.partial_subset(
- task.downstream_task_ids,
- include_downstream=True,
- include_upstream=False,
- include_direct_upstream=True,
- )
+ # partial_dag = task.dag.partial_subset(
+ # task.downstream_task_ids,
+ # include_downstream=True,
+ # include_upstream=False,
+ # include_direct_upstream=True,
+ # )
+ # Getting partial_dag is an unsafe behavior
+ partial_dag = task.dag
dag_run.dag = partial_dag
Review Comment:
If we remove it completely, it would be better to remove the `partial_dag`
variable and fix commentary accordingly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
